Skip to content

Massive pre-release refactoring#59

Merged
Malkovsky merged 3 commits into
mainfrom
feature/pre_release_refactoring
Jul 17, 2026
Merged

Massive pre-release refactoring#59
Malkovsky merged 3 commits into
mainfrom
feature/pre_release_refactoring

Conversation

@Malkovsky

@Malkovsky Malkovsky commented Jul 17, 2026

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@Malkovsky

Malkovsky commented Jul 17, 2026

Copy link
Copy Markdown
Owner Author

@codex please review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 57c4d9270d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.26112% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.10%. Comparing base (2f8881e) to head (b083588).

Files with missing lines Patch % Lines
include/pixie/io/mapped_file.h 78.72% 6 Missing and 4 partials ⚠️
include/pixie/wavelet_tree/index.h 95.52% 5 Missing and 4 partials ⚠️
src/tests/tree_tests.cpp 89.02% 0 Missing and 9 partials ⚠️
src/tests/rank_select_unittests.cc 95.08% 0 Missing and 6 partials ⚠️
include/pixie/rank_select/support.h 93.93% 1 Missing and 3 partials ⚠️
include/pixie/storage.h 94.28% 1 Missing and 1 partial ⚠️
include/pixie/storage/read_only_view.h 88.88% 1 Missing and 1 partial ⚠️
include/pixie/utils.h 66.66% 1 Missing and 1 partial ⚠️
include/pixie/rank_select.h 95.83% 0 Missing and 1 partial ⚠️
include/pixie/rmq/cartesian_hybrid_btree.h 90.90% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   89.39%   90.10%   +0.71%     
==========================================
  Files          32       39       +7     
  Lines        8637     8735      +98     
  Branches     1396     1418      +22     
==========================================
+ Hits         7721     7871     +150     
+ Misses        511      447      -64     
- Partials      405      417      +12
Flag Coverage Δ
gcov 90.10% <95.26%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Malkovsky
Malkovsky merged commit bf01091 into main Jul 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Malkovsky